Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a conditionalized attribute for the Derby database #43463

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

MichalMaler
Copy link
Contributor

The following attribute is set in a condition not to be triggered and rendered in Quarkus docs since it is not specified in attribute.adoc. However, the product version of this guide will use the attribute to mention the note regarding the Derby database support.
QE and Thomas Q. approved.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Sep 24, 2024
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I requested this, +1, though I have a feeling it might be hard to understand for community why we do that. If it is customary to add such conditional blocks without notes, LGTM.

@gsmet gsmet merged commit 9f74899 into quarkusio:main Sep 24, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

🙈 The PR is closed and the preview is expired.

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants