Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding content conditionals for the TLS guide #43658

Merged

Conversation

MichalMaler
Copy link
Contributor

@MichalMaler MichalMaler commented Oct 2, 2024

Some of this context is not currently supported in the product.
These conditionals keep the Quakus content intact while removing it from the product documentation.
An explanation was added to the code.

A decision needs to be made if these two chapters, Cert-mange and Kubernetes secret and Let's Encrypt, need to be pulled out of the product docs (or at least one of them) or kept it there and add a note about the Dev support only to it.
CC: @tqvarnst

QE approved.

@MichalMaler MichalMaler added the area/docstyle issues related for manual docstyle review label Oct 2, 2024
@MichalMaler MichalMaler requested review from cescoffier and michalvavrik and removed request for jmartisk October 2, 2024 15:40
Copy link

github-actions bot commented Oct 2, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 2, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 0ffb830.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier cescoffier merged commit e3960c7 into quarkusio:main Oct 2, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 2, 2024
@MichalMaler MichalMaler deleted the Adding-conditionals-for-the-TLS-guide branch October 2, 2024 17:50
@cescoffier
Copy link
Member

Backport using #43658.

@MichalMaler
Copy link
Contributor Author

Backport using #43658.

Thank you @cescoffier . I know this is not a normal flow. I just trying to get this done before I leave for PTO and send this for QE verification as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants