Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document RestResponse #43759

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Document RestResponse #43759

merged 1 commit into from
Oct 8, 2024

Conversation

lasteris
Copy link
Contributor

@lasteris lasteris commented Oct 7, 2024

Also, I have a bit reorganized chapters to make guide a little bit more consistent.

Also, i've a bit reorganized chapters to make guide a little bit more consistent.
@lasteris lasteris marked this pull request as ready for review October 7, 2024 22:22
Copy link

github-actions bot commented Oct 7, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 7, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 973c89d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@lasteris
Copy link
Contributor Author

lasteris commented Oct 8, 2024

@geoand Feel free to review, as you will be available for it, thank you
Also, need advice:
In Text you can see link:{jaxrsapi}/jakarta/ws/rs/core/Response.html[Response], not sure how to make this link right.

I'm not sure the example of retrieving properties from RestResponse fits well enough. Waiting for comments (

Honestly, while i was reading whole Guide many times, i thought that all text is a little bit not consistent/consecutive/logical, but maybe it is false feeling.

Upd. 1

I swapped the blocks Create the Jakarta REST resource AND Create the configuration precisely to maintain a logical sequence and not break the RestResponse description

@gastaldi gastaldi requested a review from geoand October 8, 2024 10:56
@geoand geoand merged commit f5c758b into quarkusio:main Oct 8, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Oct 8, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document RestResponse<T> in rest client
2 participants