Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GRPC Server Authentication Test Documentation to use Meta.Key #43834

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

tmulle
Copy link
Contributor

@tmulle tmulle commented Oct 11, 2024

Fix #43811
Redid the doc changes in a single commit

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 11, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@tmulle tmulle changed the title Fix #43811 Updated GRPC Server Authentication to use Meta.Key Oct 11, 2024
@tmulle tmulle changed the title Updated GRPC Server Authentication to use Meta.Key Updated GRPC Server Authentication Test Documentation to use Meta.Key Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 11, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 54706f8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks, but I will let @alesj confirm!

@alesj
Copy link
Contributor

alesj commented Oct 15, 2024

@gsmet lgtm
@tmulle when did the change from String to Metadata.Key got introduced?

@tmulle
Copy link
Contributor Author

tmulle commented Oct 15, 2024

I'm not sure the exact change, but the latest version 1.67.1 of io.grpc.Metadata shows the MetaData.Key
and the version in my project is 1.65.1 and that also uses the MetaData.Key

https://grpc.github.io/grpc-java/javadoc/io/grpc/Metadata.html

@gsmet gsmet merged commit 88a1b14 into quarkusio:main Oct 16, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC sample test documentation for Server Auth is incorrect
4 participants