Allow adding and removing extensions from Dev UI

[phillip-kruger]

This PR add the "quarkus add" and "quarkus remove" to Dev UI. It allows you to browse (and search) for installable extensions in Dev UI and install them from Dev UI. It also adds a remove button on the details screen on the extension if it can be uninstalled.

[github-actions]

🎊 PR Preview 3cfbfcb has been successfully built and deployed to https://quarkus-pr-main-43840-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

[cescoffier]

Looks like it breaks a few things :-)

[phillip-kruger]

@cescoffier yes I don't know why. The tests that breaks in CI runs fine on localhost. Maybe @maxandersen can comment ?

[gsmet]

I added a micro comment but, more importantly, before merging, I think we need to make sure this doesn't slow down the startup too much:

• Creating an ObjectMapper can be sometimes slow. Now it might just be the first ObjectMapper creation that is slow but we need to check for it.
• The second thing that worries me is that the test failures seem to point out the fact that you're trying to update the registry even when not actually doing anything related to your new feature. Updating the registry is slow so I definitely don't want us to pay the price of updating it every day if you don't need it - and there's a good chance you won't add a dependency or create a new app every day. To test that, you will have to drop the local registry artifact and see how it performs at startup.

Not saying these are actual issues or issues we cannot solve but we need to make sure this feature is not introducing a regression in daily life developer experience.

This review can be dropped once everything is sorted out but I just want to make sure nobody merges before we have checked the situation.

[phillip-kruger]

The test broke because of Remove Dev. This is now fixed, let's see what CI does

[gastaldi]

@gsmet I am not sure how to check this. You mentioned "drop the local registry artifact" - how do I do that ? I cleared my .quarkus and .jbang folders in home, but all seems fine. Any tips ?

I believe @gsmet is talking about the ~/.m2/repository/io/quarkus/registry/quarkus-non-platform-extensions/1.0-SNAPSHOT/ artifact that is downloaded once a day by the Quarkus Registry client. Try removing it and see if there is a performance impact

[phillip-kruger]

Thanks @gastaldi .

@gsmet deleting this does make the initial mvn quarkus:dev slower as it's downloading this artifacts. Very rough estimate is it add +-2 seconds to the initial quarkus:dev. From then onward it's cached so no issue.

Maybe you can test this on you laptop and see if it's noticeable for you. For me it was not.

[gastaldi]

@phillip-kruger can we somehow hit the registry when the UI to add an extension is opened?

[phillip-kruger]

@gastaldi - let me play around and l'll get back here.

[phillip-kruger]

@gastaldi @gsmet - ok I now moved that this happen when the add screen loads. So nothing on quarkus:dev anymore. I think we are good to go.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit d4c6c85.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d4c6c85.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	JVM Tests - JDK 17			Logs	Raw logs	🚧
✔️	JVM Tests - JDK 21			Logs	Raw logs	🚧
✖	JVM Tests - JDK 17 Windows	Build	Failures	Logs	Raw logs	🔍
✖	Gradle Tests - JDK 17	Build	⚠️ Check →	Logs	Raw logs	🚧
✖	Gradle Tests - JDK 17 Windows	Build	⚠️ Check →	Logs	Raw logs	🚧

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 406 more

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.security.PathMatchingHttpSecurityPolicyTest. - History - More details - Source on GitHub

java.lang.RuntimeException: io.quarkus.bootstrap.BootstrapException: Failed to create the application model for io.quarkus:quarkus-vertx-http-deployment::jar:999-SNAPSHOTnull
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:736)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: io.quarkus.bootstrap.BootstrapException: Failed to create the application model for io.quarkus:quarkus-vertx-http-deployment::jar:999-SNAPSHOTnull
	at io.quarkus.bootstrap.BootstrapAppModelFactory.resolveAppModel(BootstrapAppModelFactory.java:310)
	at io.quarkus.bootstrap.app.QuarkusBootstrap.bootstrap(QuarkusBootstrap.java:138)
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:679)
	... 1 more