Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some additional conditionals for the TLS guide #43879

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion docs/src/main/asciidoc/tls-registry-reference.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,15 @@ ifndef::no-reactive-routes[]
endif::no-reactive-routes[]
.
As a result, applications that use the TLS Registry can be ready to handle secure communications out of the box.
TLS Registry also provides features like automatic certificate reloading, Let's Encrypt (ACME) integration, Kubernetes Cert-Manager support, and compatibility with various keystore formats, such as PKCS12, PEM, and JKS.

TLS Registry also provides automatic certificate reloading
ifndef::no-lets-encrypt[]
, integration with Let's Encrypt (ACME)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed since the , you are suggesting here is present in the next line:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, now. +1

endif::no-lets-encrypt[]
ifndef::no-kubernetes-secrets-or-cert-manager[]
, support for Kubernetes Cert-Manager,
endif::no-kubernetes-secrets-or-cert-manager[]
and compatibility with various keystore formats, such as PKCS12, PEM, and JKS.

[[using-the-tls-registry]]
== Using the TLS registry
Expand Down