Update Google Cloud SQL guide #43901
Conversation
This comment has been minimized.
This comment has been minimized.
|
🙈 The PR is closed and the preview is expired. |
|
|
||
| [source,properties] | ||
| ---- | ||
| quarkus.native.additional-build-args=--initialize-at-run-time=jnr.ffi.provider.jffi.NativeFinalizer$SingletonHolder\,com.kenai.jffi.internal.Cleaner |
There was a problem hiding this comment.
There is a small typo here, there should be double backslashes to escape the comma. See: #6710 (comment)
There was a problem hiding this comment.
@loicmathieu @daniel-pettersson-pricer do you think it would make sense to have an extension here: https://github.com/quarkiverse/quarkus-google-cloud-services to handle this properly?
There was a problem hiding this comment.
Thank you @daniel-pettersson-pricer. Fixed.
There was a problem hiding this comment.
@gsmet it's not the first time we asked ourself about an extension for CloudSQL but the issue is that as it would not be tested on a real instance for practical reason (cost), this would probably not catch this kind of errors so I'm not sure it's worth the work.
There was a problem hiding this comment.
Well, that would be a good way to capitalize on things. I agree it's not going to magically fix the reported issues but at least people could get the latest fixes just by updating.
Now it's just an idea.
There was a problem hiding this comment.
Tracked here: quarkiverse/quarkus-google-cloud-services#696
zakkak
force-pushed
the
2024-10-16-fix-43876
branch
from
5f65fc0
to
489f919
Compare
Status for workflow
|
|
@daniel-pettersson-pricer thanks for the thorough review, let's get this merged and backported. |
Closes #43876
@daniel-pettersson-pricer can you please review?