-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new BuildItem class: KubernetesDevServiceRequestBuildItem #46399
Add a new BuildItem class: KubernetesDevServiceRequestBuildItem #46399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the intention of KubernetesDevServiceRequestBuildItem
has been misunderstood. The idea, is we create an alternative to configuration for controlling the DevService, so that other extension (e.g. quarkus-argocd or quarkus-tekton) can request the creation of the DevService.
So, I added some suggestions. But we still need more things: Consume the KubenretesDevServiceBuildItem
and check if its present so that we can start the dev service.
...nt/src/main/java/io/quarkus/kubernetes/client/deployment/DevServicesKubernetesProcessor.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/io/quarkus/kubernetes/client/deployment/DevServicesKubernetesProcessor.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/io/quarkus/kubernetes/client/deployment/DevServicesKubernetesProcessor.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...nt/src/main/java/io/quarkus/kubernetes/client/deployment/DevServicesKubernetesProcessor.java
Outdated
Show resolved
Hide resolved
...spi/src/main/java/io/quarkus/kubernetes/client/spi/KubernetesDevServiceRequestBuildItem.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's squash and I'll merge once CI greenlights things.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e64273f
to
d201100
Compare
…it against PR: quarkusio/quarkus#46399 Signed-off-by: cmoulliard <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…new class KubernetesDevServiceRequestBuildItem to allow to request to launch a kind cluster from and extension. Document the code using javadoc for the the newly created classes. Remove the non needed callout Signed-off-by: cmoulliard <[email protected]> Co-authored-by: Ioannis Canellos <[email protected]>
aa116c3
to
38882ec
Compare
Status for workflow
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
KubernetesDevServiceRequestBuildItem
and adapt the code to instantiate it part of the step creating the kind container