Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new BuildItem class: KubernetesDevServiceRequestBuildItem #46399

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

cmoulliard
Copy link
Contributor

  • Review the kubernetes dev service documentation (adoc file)to improve it,
  • Add a new class KubernetesDevServiceRequestBuildItem and adapt the code to instantiate it part of the step creating the kind container
  • Include the javadoc annotations for the newly created classes

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the intention of KubernetesDevServiceRequestBuildItem has been misunderstood. The idea, is we create an alternative to configuration for controlling the DevService, so that other extension (e.g. quarkus-argocd or quarkus-tekton) can request the creation of the DevService.

So, I added some suggestions. But we still need more things: Consume the KubenretesDevServiceBuildItem and check if its present so that we can start the dev service.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@iocanel iocanel self-requested a review February 26, 2025 09:06
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's squash and I'll merge once CI greenlights things.

@iocanel iocanel added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 26, 2025

This comment has been minimized.

This comment has been minimized.

@cmoulliard cmoulliard force-pushed the create-kube-devservices-request branch from e64273f to d201100 Compare February 26, 2025 09:54
cmoulliard added a commit to ch007m/fork-quarkus-argocd that referenced this pull request Feb 26, 2025

This comment has been minimized.

This comment has been minimized.

…new class KubernetesDevServiceRequestBuildItem to allow to request to launch a kind cluster from and extension. Document the code using javadoc for the the newly created classes. Remove the non needed callout

Signed-off-by: cmoulliard <[email protected]>
Co-authored-by: Ioannis Canellos <[email protected]>
@cmoulliard cmoulliard force-pushed the create-kube-devservices-request branch from aa116c3 to 38882ec Compare February 26, 2025 10:41
Copy link

quarkus-bot bot commented Feb 26, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 38882ec.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

github-actions bot commented Feb 26, 2025

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Feb 26, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 38882ec.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@iocanel iocanel merged commit 1516508 into quarkusio:main Feb 26, 2025
34 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 26, 2025
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants