Feature/scan mode #388
Merged
Feature/scan mode #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
commented
Jun 22, 2021
ryan-summers
commented
Jun 22, 2021
|
And from an application perspective we should maybe first implement this on |
ryan-summers
commented
Jun 28, 2021
jordens
requested changes
Jun 29, 2021
jordens
requested changes
Jul 8, 2021
|
bors try |
tryBuild succeeded: |
|
I have refactored the signal generation use of symmetry (now 0-1) and tested across a range of symmetries, signals, and amplitudes. All currently looks to be operating as expected. |
jordens
requested changes
Jul 19, 2021
Co-authored-by: Robert Jördens <[email protected]>
ryan-summers
force-pushed
the
feature/scan-mode
branch
from
99ebdc6 to
1c32695
Compare
jordens
approved these changes
Jul 19, 2021
|
bors r+ |
|
Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add visibility on design decisions for the scan mode implementation for #86
This PR:
dual-iirTesting:
The new signal generator was scanned across 0-100% symmetry for all waveform types using frequencies of 500-1KHz. It was observed on an oscilloscope to contain nominal, well-formed outputs.