Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly shallow copy nested element for includes #12214

Merged
merged 7 commits into from
Mar 5, 2025
Merged

correctly shallow copy nested element for includes #12214

merged 7 commits into from
Mar 5, 2025

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Mar 5, 2025

fix #12204

this is a follow up of

This PR also tweaks printMessages in smoke-all so that we can write more explicitly our test
Example:

_quarto:
  tests: 
    html:
      printsMessage:
        level: INFO
        regex: 'FATAL[\s\S]*Error resolving header-includes'
        negate: true

cderv added 7 commits March 5, 2025 13:42
@cderv
shallow copy nested includes to avoid freeze processing to modify inc…
eda2ff8 
…ludes unexpectedly
@cderv
test - don't remove project dir when no output dir.
414403f
@cderv
test - improve how to use printMessages in smoke-all test using nam…
13765bc 
…ed YAML field
@cderv
Add a test for FATAL error when reading header-include-
6accac6 
the test uses `printMessages` with INFO level because somehow the `fail()` call in LUA does not log as error and so `noErrors` verify check does not catch the error.
@cderv
don't need shallow copy when we create new object
640976b 
which is the case using `.map()`
@cderv
Ignore tests/venv and tests/env only
a05b1af 
and not tests/smoke/env
@cderv
More tests need new syntax for printMessages
b523ebf
@cderv cderv merged commit 91c665a into main Mar 5, 2025
47 checks passed
@cderv cderv deleted the execute-header-include branch March 5, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error resolving header-includes with juliaengine
1 participant
@cderv