Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Support writing components as Vue files #19

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mesqueeb
Copy link
Contributor

@mesqueeb mesqueeb commented Oct 5, 2019

fixes #18

@mesqueeb mesqueeb changed the title Support vue files Support writing components as Vue files Nov 14, 2019
@mesqueeb
Copy link
Contributor Author

mesqueeb commented Dec 13, 2019

@rstoenescu do you see any other problems supporting Vue files for UI extensions?

This PR has worked for all my UI extensions which are all written as Vue files. 😉

@mesqueeb
Copy link
Contributor Author

mesqueeb commented May 2, 2020

fixed merge conflicts

@mesqueeb
Copy link
Contributor Author

fixed new merge conflicts

@rstoenescu any chance this can get merged? Your feedback is much appreciated!

@ldiebold
Copy link

Would love to see this in the ui kit!

my use case is creating a simple, default login form to go with a Laravel Sanctum login extension.
It gets pretty ugly without .vue component!

@ldiebold
Copy link

Any updates on this?
This article seems to have received a lot of attention, and would not be a problem if this wes merged!
https://medium.com/@jdmccormack63/creating-a-quasar-ui-app-extension-component-library-5b3085327d5a

@ldiebold
Copy link

We would just have to make it clear in the docs, that render functions should be used where possible because they're

  • Easier to debug
  • provide more flexibility

@mesqueeb
Copy link
Contributor Author

I think those statements are opinions not facts. Something is only as flexible as a developers imagination, and a more difficult to read format can lead to a higher difficulty and limiting the developer's creativity therefore being less flexible.

When it comes to ease of debugging usually the most important thing is code readbility, which I argue is higher with Vue files as well....

@ldiebold
Copy link

@mesqueeb These thoughts are not my own, was parroting what I've heard in the quasar community.
It would almost certainly make it easier for others to get started making their own UI components.

@hawkeye64 what are your thoughts?

Our use case for quasar extensions, is organizing components across applications (we have several small PWAs). We plan to create full login flows so that this logic remains dry by using app extensions. Creating a full login page without SFCs doesn't feel right.

That's our use case for wanting SFCs, and I imagine similar use cases may become more common.

@hawkeye64
Copy link
Member

@ldiebold Create a new UI kit project. Add the appropriate SFC handling. Add to github and mark as template. Use as necessary.
I kind of think, with Vue 3, this is going to hange anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make compatible with regular vue files
3 participants