Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

eslint: Add vue setup compiler macros #173

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

tennox
Copy link

@tennox tennox commented Feb 18, 2022

See:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@tennox tennox changed the base branch from master to dev February 18, 2022 03:13
@IlCallo
Copy link
Member

IlCallo commented Feb 18, 2022

Hey there!
Thanks for your contribution, do you know if there's any other thing which must be configured when using script setup at ESLint level?
I noticed there are some other Vue rules which should be adapted

Do you have the time to add a prompt question asking "do you plan to use <script setup>?" or similar (with an appropriate link) and enable those rules just for who accept it?
Otherwise I'll just merge the PR and we'll deal with other script setup issues later on

@tennox
Copy link
Author

tennox commented Feb 18, 2022

Hi, so I've figured, the setting in this PR only works when upgrading eslint-plugin-vue to v8

Is this feasible for the starter kit?
(I know it works - I'm using it)

If yes I can also do the work of checking with a fresh start kit what is needed for other script setup things.

@IlCallo
Copy link
Member

IlCallo commented Feb 18, 2022

I think half of the ecosystem is waiting for eslint-plugin-node to support ESLint 8
See #167

We could just do the upgrade for some ESLint presets, but it would be hard to maintain, that's why we are waiting to do the switch

@tennox
Copy link
Author

tennox commented Feb 19, 2022

I see... works fine for me, but I see there are still issues so this PR will have to wait 💁‍♂️

Added a shy bump to the eslint-plugin-node issue 😋

Thx :)

@IlCallo
Copy link
Member

IlCallo commented Feb 21, 2022

Thanks to you for caring and proposing a fix :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants