fix(app-webpack): (backport from q/app-webpack v4 beta) Capacitor/Cor…

…dova on Windows host -> Android Studio not being launched when running "quasar build -m capacitor -T android --ide" #17420

app-webpack/lib/capacitor/index.js

@@ -6,6 +6,7 @@ const { spawn, spawnSync } = require('../helpers/spawn')
 const onShutdown = require('../helpers/on-shutdown')
 const appPaths = require('../app-paths')
 const openIde = require('../helpers/open-ide')
+const { SIGNAL__BUILD_SHOULD_EXIT } = require('../helpers/signals.js')
 
 const { capBin } = require('./cap-cli')
 
@@ -61,7 +62,7 @@ class CapacitorRunner {
 
     if (argv.ide === true) {
       await openIde('capacitor', cfg.bin, this.target)
-      process.exit(0)
+      return SIGNAL__BUILD_SHOULD_EXIT
     }
 
     if (this.target === 'ios') {

app-webpack/lib/cmd/build.js

@@ -261,7 +261,12 @@ async function build () {
         console.error(err)
         fatal('Failed to finalize build (check the log above)', 'FAIL')
       })
-      .then(async () => {
+      .then(async signal => {
+        if (signal !== void 0) {
+          const { SIGNAL__BUILD_SHOULD_EXIT } = await import('../helpers/signals.js')
+          if (signal === SIGNAL__BUILD_SHOULD_EXIT) return
+        }
+
         outputFolder = argv.mode === 'cordova'
           ? path.join(outputFolder, '..')
           : outputFolder

app-webpack/lib/cordova/index.js

@@ -6,6 +6,7 @@ const { spawn } = require('../helpers/spawn')
 const onShutdown = require('../helpers/on-shutdown')
 const appPaths = require('../app-paths')
 const openIde = require('../helpers/open-ide')
+const { SIGNAL__BUILD_SHOULD_EXIT } = require('../helpers/signals.js')
 
 const cordovaOutputFolders = {
   ios: [
@@ -119,7 +120,7 @@ class CordovaRunner {
 
     if (argv.ide) {
       await openIde('cordova', quasarConf.bin, this.target)
-      process.exit(0)
+      return SIGNAL__BUILD_SHOULD_EXIT
     }
 
     const targetFolder = quasarConf.build.packagedDistDir

app-webpack/lib/helpers/open-ide.js

@@ -24,20 +24,19 @@ function runMacOS (mode, target) {
       ? appPaths.resolve.cordova('platforms/ios')
       : appPaths.resolve.capacitor('ios/App')
 
-    open(findXcodeWorkspace(folder), {
+    return open(findXcodeWorkspace(folder), {
       wait: false
     })
   }
-  else {
-    const folder = mode === 'cordova'
-      ? appPaths.resolve.cordova('platforms/android')
-      : appPaths.resolve.capacitor('android')
 
-    open(folder, {
-      app: { name: 'android studio' },
-      wait: false
-    })
-  }
+  const folder = mode === 'cordova'
+    ? appPaths.resolve.cordova('platforms/android')
+    : appPaths.resolve.capacitor('android')
+
+  return open(folder, {
+    app: { name: 'android studio' },
+    wait: false
+  })
 }
 
 function getLinuxPath (bin) {
@@ -69,12 +68,10 @@ function runLinux (mode, bin, target) {
         ? appPaths.resolve.cordova('platforms/android')
         : appPaths.resolve.capacitor('android')
 
-      open(folder, {
+      return open(folder, {
         app: { name: studioPath },
         wait: false
       })
-
-      return
     }
   }
   else if (target === 'ios') {
@@ -122,16 +119,10 @@ function runWindows (mode, bin, target) {
         ? appPaths.resolve.cordova('platforms/android')
         : appPaths.resolve.capacitor('android')
 
-      open(folder, {
+      return open(folder, {
         app: { name: studioPath },
         wait: false
       })
-
-      // pause required, otherwise Windows fails
-      // to open the process
-      return new Promise(resolve => {
-        setTimeout(resolve, 300)
-      })
     }
   }
   else if (target === 'ios') {
@@ -144,10 +135,12 @@ function runWindows (mode, bin, target) {
   process.exit(1)
 }
 
-module.exports = function (mode, bin, target, dev) {
+// openIde() returns the result of an open() call (which is a Promise)
+// so this function should be treated as async
+module.exports = function openIde (mode, bin, target, dev) {
   console.log()
   console.log(' ⚠️  ')
-  console.log(` ⚠️  Opening ${ target === 'ios' ? 'XCode' : 'Android Studio' } IDE...`)
+  console.log(` ⚠️  Opening ${ target === 'ios' ? 'XCode' : 'Android Studio' } IDE. It might take a few seconds...`)
 
   if (dev) {
     console.log(' ⚠️  From there, use the IDE to run the app.')

app-webpack/lib/helpers/signals.js

@@ -0,0 +1 @@
+module.exports.SIGNAL__BUILD_SHOULD_EXIT = 'SIGNAL__BUILD_SHOULD_EXIT'