feat(Notify): allow exponential notation for timeout

quasarframework · Dec 18, 2023 · a59eb69 · a59eb69
1 parent 2723585
commit a59eb69
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/ui/src/plugins/Notify.js b/ui/src/plugins/Notify.js
@@ -19,6 +19,7 @@ const notificationsList = {}
 const positionClass = {}
 const emptyRE = /^\s*$/
 const notifRefs = []
+const invalidTimeoutValues = [ void 0, null, true, false, '' ]
 
 const positionList = [
   'top-left', 'top-right',
@@ -112,15 +113,15 @@ function addNotification (config, $q, originalApi) {
     notif.position = 'bottom'
   }
 
-  if (notif.timeout === void 0) {
+  if (invalidTimeoutValues.includes(notif.timeout) === true) {
     notif.timeout = 5000
   }
   else {
-    const t = parseInt(notif.timeout, 10)
+    const t = Number(notif.timeout) // we catch exponential notation too with Number() casting
     if (isNaN(t) || t < 0) {
       return logError('wrong timeout', config)
     }
-    notif.timeout = t
+    notif.timeout = Number.isFinite(t) ? t : 0
   }
 
   if (notif.timeout === 0) {

diff --git a/ui/src/plugins/Notify.json b/ui/src/plugins/Notify.json
@@ -166,7 +166,7 @@
 
       "timeout": {
         "type": "Number",
-        "desc": "Amount of time to display (in milliseconds)",
+        "desc": "Amount of time to display (in milliseconds). Set to 0 to never dismiss automatically.",
         "default": 5000
       },
 
@@ -392,7 +392,7 @@
 
             "timeout": {
               "type": "Number",
-              "desc": "Amount of time to display (in milliseconds)",
+              "desc": "Amount of time to display (in milliseconds). Set to 0 to never dismiss automatically.",
               "default": 5000,
               "examples": [ 2500 ]
             },