Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): q-item within QMenu should be selectable using the space key (fix: #16107) #16364

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

amal-qb
Copy link
Contributor

@amal-qb amal-qb commented Sep 19, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Fixes #16107

Amal Mathew and others added 2 commits September 19, 2023 16:40
@amal-qb
Copy link
Contributor Author

amal-qb commented Sep 20, 2023

@yusufkandemir Could you please check why the UI tests are failing with below error:

error @quasar/[email protected]: The engine "node" is incompatible with this module. Expected version "^30 || ^28 || ^26 || ^24 || ^22 || ^20 || ^18". Got "16.20.2"

@yusufkandemir
Copy link
Member

@amal-qb the issue is clear, the workflows are using Node 16 which is not supported in app-vite v2 beta. I have fixed it: 7a7444a
You need to rebase your PR to get it to run using the updated workflow.

@github-actions
Copy link

UI Tests Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
2 files    0
2 errors

For more details on these parsing errors, see this check.

Results for commit abb376e.

@amal-qb
Copy link
Contributor Author

amal-qb commented Sep 20, 2023

@yusufkandemir Thanks! But now I'm getting an error for the "UI Tests Results" check:

Error processing result file

image

@yusufkandemir
Copy link
Member

@amal-qb it's been like that for a while, you can ignore it for now. I will investigate it another time.

@rstoenescu rstoenescu merged commit 9d62833 into quasarframework:dev Oct 26, 2023
3 of 4 checks passed
@rstoenescu
Copy link
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The q-item within QMenu cannot be selected using the space key.
3 participants