Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(QDialog): add QDialog tests #16636

Merged
merged 10 commits into from
Feb 23, 2024
Merged

test(QDialog): add QDialog tests #16636

merged 10 commits into from
Feb 23, 2024

Commits on Feb 22, 2024

  1. test(QDialog): add QDialog tests

    @n05la3
    n05la3 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    89c025a View commit details
    Browse the repository at this point in the history

  2. test(QDialog): improve test stability

    @n05la3
    n05la3 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4331e4d View commit details
    Browse the repository at this point in the history

  3. test(use-model-toggle): improve test stability

    @n05la3
    n05la3 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    352bc35 View commit details
    Browse the repository at this point in the history

  4. test(QDialog): refactor and fix some tests

    @IlCallo @n05la3
    IlCallo authored and n05la3 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    2667f10 View commit details
    Browse the repository at this point in the history

  5. test(QDialog): refactor and improve tests

    @n05la3
    n05la3 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    173e6d4 View commit details
    Browse the repository at this point in the history

  6. chore(ui) upgrade test deps

    @IlCallo @n05la3
    IlCallo authored and n05la3 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    91e9f00 View commit details
    Browse the repository at this point in the history

  7. test(QDialog): refactor some tests to be more readable

    @IlCallo @n05la3
    IlCallo authored and n05la3 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    bfcd7a3 View commit details
    Browse the repository at this point in the history

  8. test(use-model-toggle): revert changes on use-model-toggle and prefer… 

    … stopping animation on QMenu to fix event issues

- After a dialog has been closed, the hide event is fired only after the duration transitionDuration has elapsed. transitionDuration is a prop passed to use-model-toggle.js and has a default value of 300ms. Hence, we cannot depend on the dialog closing to conclude that the event has been fired. Setting transitionDuration to 0 ensures it fires immediately
    @n05la3
    n05la3 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    91d8345 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. test(use-model-toggle): add test for 'hide' event interaction with tr… 

    …ansition duration prop
    @n05la3
    n05la3 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e26f9ee View commit details
    Browse the repository at this point in the history

  2. test(QDialog): apply vModelAdapter fix

    @IlCallo
    IlCallo committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a7d5a1f View commit details
    Browse the repository at this point in the history