Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate the monorepo to pnpm #16990

Merged
merged 29 commits into from
Mar 13, 2024

Conversation

yusufkandemir
Copy link
Member

What kind of change does this PR introduce?

  • Other, please describe: migrate the repo to pnpm workspaces from yarn workspaces / npm mix

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)

Other information:
Summary of changes:

  • migrate to pnpm from yarn/npm mix
  • add app-webpack, cli, and create-quasar to workspaces
  • update CI workflows
  • improve/centralize linting configuration/packages
  • reference the active package manager in app-vite/app-webpack banners
  • print pnpm and bun versions in quasar info
  • improve/fix some package-manager-related types in app-vite/app-webpack
  • improve package-manager-related mentions in docs
  • improve the contribution guide in the docs, and reference the docs in /CONTRIBUTING.md and .github/CONTRIBUTING.md to avoid duplicate/out-of-sync content
  • update VS Code configuration

This comment has been minimized.

Copy link

github-actions bot commented Mar 12, 2024

UI Tests Results

   74 files  1 701 suites   2m 1s ⏱️
  504 tests   504 ✅ 0 💤 0 ❌
1 566 runs  1 566 ✅ 0 💤 0 ❌

Results for commit 4a4c01c.

♻️ This comment has been updated with latest results.

after migrating to pnpm workspaces, some behavior got changed
1. prompts package named imports are not working. This is probably due to switching to a different version during migration, rather than a pnpm specific issue.
2. When using pnpm to create the test project, it becomes part of the monorepo, which makes it fail to install properly.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

but still keep it in create-test-project script to avoid the problem when executing the script in different environments

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

Build Results

JSON API

📜 No changes detected.

Types

📜 Changes detected:

diff --git a/./current-build/types/tsconfig.json b/./pr-build/types/tsconfig.json
index 56822e7..8cb4af8 100644
--- a/./current-build/types/tsconfig.json
+++ b/./pr-build/types/tsconfig.json
@@ -4,7 +4,7 @@
     "lib": ["es2015", "dom"],
     "paths": {
       "quasar": [
-        // index.d.ts is auto-generated by the build process ("yarn build js types")
+        // index.d.ts is auto-generated by the build process ("pnpm build js types")
         // It contains auto-generated types like QInput, QInputProps, etc.
         // To reference those types, import them from "quasar"
         // For other types defined in this directory, use relative imports

@rstoenescu rstoenescu merged commit 7f8e550 into quasarframework:dev Mar 13, 2024
30 checks passed
@yusufkandemir yusufkandemir deleted the migrate-to-pnpm branch March 13, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants