-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate the monorepo to pnpm #16990
Merged
rstoenescu
merged 29 commits into
quasarframework:dev
from
yusufkandemir:migrate-to-pnpm
Mar 13, 2024
Merged
chore: migrate the monorepo to pnpm #16990
rstoenescu
merged 29 commits into
quasarframework:dev
from
yusufkandemir:migrate-to-pnpm
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it needs to be specified in the root since we are using pnpm workspaces but, it doesn't seem to be changing any behavior, so it's redundant
This comment has been minimized.
This comment has been minimized.
UI Tests Results 74 files 1 701 suites 2m 1s ⏱️ Results for commit 4a4c01c. ♻️ This comment has been updated with latest results. |
after migrating to pnpm workspaces, some behavior got changed 1. prompts package named imports are not working. This is probably due to switching to a different version during migration, rather than a pnpm specific issue. 2. When using pnpm to create the test project, it becomes part of the monorepo, which makes it fail to install properly.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
but still keep it in create-test-project script to avoid the problem when executing the script in different environments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
and correctly cache it
This comment has been minimized.
This comment has been minimized.
Build ResultsJSON API📜 No changes detected. Types📜 Changes detected: diff --git a/./current-build/types/tsconfig.json b/./pr-build/types/tsconfig.json
index 56822e7..8cb4af8 100644
--- a/./current-build/types/tsconfig.json
+++ b/./pr-build/types/tsconfig.json
@@ -4,7 +4,7 @@
"lib": ["es2015", "dom"],
"paths": {
"quasar": [
- // index.d.ts is auto-generated by the build process ("yarn build js types")
+ // index.d.ts is auto-generated by the build process ("pnpm build js types")
// It contains auto-generated types like QInput, QInputProps, etc.
// To reference those types, import them from "quasar"
// For other types defined in this directory, use relative imports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
dev
branch (orv[X]
branch)Other information:
Summary of changes:
quasar info
/CONTRIBUTING.md
and.github/CONTRIBUTING.md
to avoid duplicate/out-of-sync content