Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix QOptionGroup options type (fix: #17710) #17755

Conversation

yusufkandemir
Copy link
Member

to respect option-label and option-value props

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

Other information:
Fixes #17710

to respect option-label and option-value props
@rstoenescu
Copy link
Member

The information is valuable in the JSON displayed in docs & also in the web-types etc. Rather than dropping all those props, let's add a "tsType: false" to each of those props -- so that only our TS build script will ignore it.

@yusufkandemir
Copy link
Member Author

I went with a solution similar to the QSelect options prop. The documentation explains the rest. Furthermore, having them there might be confusing when keeping option-value, option-disable, etc. props in mind. If you still think we should add new logic around tsType to accept false and behave differently, I, unfortunately, don't have time for it to implement, test, etc. I also think it will open a new rabbit hole, to adapt it to some other places.

@rstoenescu
Copy link
Member

Went with a more appropriate description for the "options" for both QOptionGroup & QSelect.

@rstoenescu rstoenescu closed this Jan 16, 2025
@yusufkandemir
Copy link
Member Author

Reference: d07b4fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QOptionGroup invalid type of options for typescript
2 participants