Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: add function to determine if paths are RPM #1473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

crozzy
Copy link
Contributor

@crozzy crozzy commented Jan 24, 2025

Allow language indexers to check if the filepaths they are interested in have been installed via RPM.

The first iteration of this came in the form of #1320 which would save all the RPM files with an rpm.Filescanner and compare them to the language Package's file during the Resolve step however it required saving lots of filepath data to the database in order to make the determination.

This changeset allows dynamic checking of RPM files during language indexing (akin to how we use the INSTALLER file currently) without the extra storage requirements (that could be huge with a large, diverse corpus of images). Also, as the results are cached for the request duration we don't need to trade reduced storage for increased memory/io.

@crozzy crozzy force-pushed the rpm-filechecker branch 3 times, most recently from 244e040 to 364e886 Compare January 28, 2025 22:53
@crozzy
Copy link
Contributor Author

crozzy commented Jan 28, 2025

supersedes #1320

@crozzy crozzy marked this pull request as ready for review January 28, 2025 23:10
@crozzy crozzy requested a review from a team as a code owner January 28, 2025 23:10
@crozzy crozzy requested review from RTann and removed request for a team January 28, 2025 23:10
@crozzy crozzy force-pushed the rpm-filechecker branch 2 times, most recently from 48703f5 to 25156b2 Compare February 4, 2025 23:17
@crozzy crozzy requested a review from RTann February 4, 2025 23:24
BradLugo
BradLugo previously approved these changes Feb 6, 2025
Copy link
Contributor

@BradLugo BradLugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @RTann's comments are resolved

@crozzy crozzy force-pushed the rpm-filechecker branch 3 times, most recently from 83b1075 to 0eacf93 Compare February 6, 2025 16:14
@crozzy crozzy requested a review from RTann February 6, 2025 16:40
Allow language indexers to check if the filepaths they are interested in
have been installed via RPM.

Signed-off-by: crozzy <[email protected]>
Check whether interesting paths were installed by RPM during language
level indexing.

Signed-off-by: crozzy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants