-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpm: add function to determine if paths are RPM #1473
Open
crozzy
wants to merge
2
commits into
quay:main
Choose a base branch
from
crozzy:rpm-filechecker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
352f59f
to
adba6a6
Compare
crozzy
commented
Jan 27, 2025
244e040
to
364e886
Compare
supersedes #1320 |
RTann
reviewed
Jan 29, 2025
364e886
to
ff26c54
Compare
ff26c54
to
e4b2fdf
Compare
RTann
reviewed
Feb 3, 2025
48703f5
to
25156b2
Compare
RTann
reviewed
Feb 4, 2025
RTann
reviewed
Feb 5, 2025
BradLugo
reviewed
Feb 5, 2025
BradLugo
previously approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after @RTann's comments are resolved
83b1075
to
0eacf93
Compare
RTann
reviewed
Feb 7, 2025
RTann
reviewed
Feb 7, 2025
0eacf93
to
8c8c5d7
Compare
Allow language indexers to check if the filepaths they are interested in have been installed via RPM. Signed-off-by: crozzy <[email protected]>
Check whether interesting paths were installed by RPM during language level indexing. Signed-off-by: crozzy <[email protected]>
8c8c5d7
to
5331a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow language indexers to check if the filepaths they are interested in have been installed via RPM.
The first iteration of this came in the form of #1320 which would save all the RPM files with an rpm.Filescanner and compare them to the language Package's file during the
Resolve
step however it required saving lots of filepath data to the database in order to make the determination.This changeset allows dynamic checking of RPM files during language indexing (akin to how we use the INSTALLER file currently) without the extra storage requirements (that could be huge with a large, diverse corpus of images). Also, as the results are cached for the request duration we don't need to trade reduced storage for increased memory/io.