Merge pull request #16 from quentinlampin/bugfix-CoAP-option-value

[Bugfix] CoAP zero-length option value
quentinlampin · Aug 23, 2023 · 3fdbff4 · 3fdbff4
2 parents 63c574b + 628302c
commit 3fdbff4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/microschc/__init__.py b/microschc/__init__.py
@@ -1 +1 @@
-__version__ = '0.15.1'
+__version__ = '0.15.2'
diff --git a/microschc/parser/protocol/coap.py b/microschc/parser/protocol/coap.py
@@ -216,8 +216,9 @@ def _parse_options(buffer: Buffer) -> Tuple[List[FieldDescriptor], int]:
             option_offset += 16
 
         option_value_length = (option_length_int + option_length_extended_int) * 8
-        option_value: Buffer = option_bytes[option_offset: option_offset+option_value_length]
-        fields.append(FieldDescriptor(id=CoAPFields.OPTION_VALUE, position=option_index, value=option_value))
+        if option_value_length > 0:
+            option_value: Buffer = option_bytes[option_offset: option_offset+option_value_length]
+            fields.append(FieldDescriptor(id=CoAPFields.OPTION_VALUE, position=option_index, value=option_value))
 
         option_offset += option_value_length
         cursor += option_offset

diff --git a/tests/test_microschc.py b/tests/test_microschc.py
@@ -2,4 +2,4 @@
 
 
 def test_version():
-    assert __version__ == '0.15.1'
+    assert __version__ == '0.15.2'
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,4 +2,4 @@


		def test_version():
		assert __version__ == '0.15.1'
		assert __version__ == '0.15.2'