Introduce support for Microsoft SQL Server #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I couldn't quite grok was how to create the database in SQLserver at startup if it didn't exist, I had to manually create it. |
|
Closed without merging (see #69 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to use MS SQL Server with SMUI!!!
This was much less painful than I expected ;-). I had to adjust down the size of the JSON payload to work with MSSqlServer, and the database locking I had to swap to false.
I tried to add the MS SQL Server jar file via dockerfile, and mess with adding a classpath etc, but no joy, so I just added it to the project.
I know some people have strong opinions on Microsoft, however I'd like to merge this as a LOT of ecomm firms are .NET shops, and using MS SQL Server makes deployment of SMUI easier. Especially at the non Super tech forward firms that maybe aren't all up on Docker.