This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
Update COMPARABLE TypeCategory so that java.util.UUID instances are deemed to be comparable #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eemed to be comparable
Shredder121
suggested changes
Dec 25, 2017
| @@ -50,7 +50,7 @@ | |||
| /** | |||
| * | |||
| */ | |||
| COMPARABLE(SIMPLE), | |||
| COMPARABLE(SIMPLE, java.util.UUID.class.getName()), | |||
There was a problem hiding this comment.
This would bleed the change to the COMPARABLE category into DATE, DATETIME...
So this is not the correct solution.
|
Hi @Shredder121. I am new to this code so I am not sure I follow. Can you elaborate? |
|
I mean, semantically the sub- |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in this PR solves querydsl issue 2220 (querydsl/querydsl#2220, which is documented in more detail here: https://groups.google.com/forum/m/#!msg/querydsl/iS0fNn16EO4/Hj6JJ3ACAgAJ).