Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for xml charset and bug of "Incorrect NumInGroup" #368

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

gpmn
Copy link

@gpmn gpmn commented Mar 2, 2019

for "Incorrect NumInGroup"
#366
#365

for xml charset:
#363

@demget
Copy link

demget commented Sep 2, 2020

The "Incorrect NumInGroup" fix should be merged

@ackleymi
Copy link
Member

ackleymi commented May 8, 2023

@demget please rebase and add a test to verify.

@ackleymi ackleymi merged commit 4ffb52e into quickfixgo:main Oct 27, 2023
12 checks passed
albertsundjaja pushed a commit to albertsundjaja/quickfix that referenced this pull request Apr 10, 2024
partly revert change in quickfixgo#368 due to breaking the unit test added in this PR
albertsundjaja pushed a commit to albertsundjaja/quickfix that referenced this pull request Apr 10, 2024
partly revert change in quickfixgo#368 due to breaking the unit test added in this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants