Fix sequence number bug when storage fails #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letian0805
force-pushed
the
fix/sequence_number_bug
branch
from
34a36ec
to
9d890e4
Compare
letian0805
force-pushed
the
fix/sequence_number_bug
branch
from
884ed80
to
abcd695
Compare
|
@letian0805 please rebase, this is something I am interested in seeing get merged. |
letian0805
force-pushed
the
fix/sequence_number_bug
branch
2 times, most recently
from
276a3dd
to
9a26a53
Compare
@ackleymi The performance optimization parts are incompatible with existing unit tests, I'll break them out separately. Fix the sequence number bug first. |
letian0805
force-pushed
the
fix/sequence_number_bug
branch
from
35f1be2
to
b85ce2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If update sequence number cache before store it to mongodb, sql or file, and then get an error, will cause the sequence number to be discontinuous. So, store sequence number before update cache.