Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bytecode stack frame printing #686

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

bnoordhuis
Copy link
Contributor

Handle OP_get_loc0_loc1 specially. Fixes an off-by-one when printing variable names.

Fixes: #683

Handle OP_get_loc0_loc1 specially. Fixes an off-by-one when printing
variable names.

Fixes: quickjs-ng#683
Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approval 😅

@bnoordhuis bnoordhuis merged commit b5d4181 into quickjs-ng:master Nov 14, 2024
47 checks passed
@bnoordhuis bnoordhuis deleted the fix683 branch November 14, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dump_byte_code() not computing the correct local index for get_loc / put_loc
2 participants