Compression #277
ci.yml
on: pull_request
Check (fmt, dependency check, clippy, test)
1m 53s
Annotations
3 errors and 2 warnings
needlessly taken reference of both operands:
chitchat/src/delta.rs#L256
error: needlessly taken reference of both operands
--> chitchat/src/delta.rs:256:34
|
256 | .find(|node_delta| { &node_delta.chitchat_id == &chitchat_id })
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `-D clippy::op-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::op_ref)]`
help: use the values directly
|
256 | .find(|node_delta| { node_delta.chitchat_id == chitchat_id })
| ~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~
|
called `is_none()` after searching an `Iterator` with `find`:
chitchat/src/delta.rs#L253
error: called `is_none()` after searching an `Iterator` with `find`
--> chitchat/src/delta.rs:253:17
|
253 | assert!(self
| _________________^
254 | | .node_deltas
255 | | .iter()
256 | | .find(|node_delta| { &node_delta.chitchat_id == &chitchat_id })
257 | | .is_none());
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
= note: `-D clippy::search-is-some` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::search_is_some)]`
help: use `!_.any()` instead
|
253 ~ assert!(!self
254 + .node_deltas
255 ~ .iter().any(|node_delta| { &node_delta.chitchat_id == &chitchat_id }));
|
|
Check (fmt, dependency check, clippy, test)
Clippy had exited with the 101 exit code
|
Check (fmt, dependency check, clippy, test)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Check (fmt, dependency check, clippy, test)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|