feat: Improved autocompletion #135
Open
+24
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uptickmetachu
changed the title
|
Hey @uptickmetachu! thanks for your contribution! Let me review it and get back to you. |
fmassot
reviewed
Aug 17, 2024
fmassot
reviewed
Aug 17, 2024
fmassot
reviewed
Aug 17, 2024
| @@ -41,6 +40,12 @@ export function LuceneQueryEditor(props: LuceneQueryEditorProps){ | |||
| if (!word){ return null } | |||
| suggestions = await autocompleter(word?.text); | |||
| if (suggestions && suggestions.options.length > 0 ) { | |||
| // Fixes autocompletion inserting an extra quote when the cursor is before a quote | |||
There was a problem hiding this comment.
does it make sense to only check that last character?
I don't understand the slice with context.pos. Can you explain exactly what we want to check here?
There was a problem hiding this comment.
does it make sense to only check that last character?
I've modified it to check for all characters following the cursor for a double quote instead of just the immediate character.
"quickwit-indexing/src/actors/indexing_pipeline.rs"
Some examples of autocompletion where ↑ is the current cursor position.:
- Example of completing immediately behind a double quote:
events.event_attributes.code.filepath:"quickwit-indexing/src/actors/↑"
- The returned completion would omit the final quote
"quickwit-indexing/src/actors/indexing_pipeline.rs. - Applying the completion would give us:
events.event_attributes.code.filepath:"quickwit-indexing/src/actors/indexing_pipeline.rs" - The current behaviour would instead give us:
events.event_attributes.code.filepath:"quickwit-indexing/src/actors/indexing_pipeline.rs""
- Example of completing without quotes:
events.event_attributes.code.filepath:↑
- The returned completion would be surrounded by quotes
"quickwit-indexing/src/actors/indexing_pipeline.rs". - Applying the completion would give us:
events.event_attributes.code.filepath:"quickwit-indexing/src/actors/indexing_pipeline.rs"
- Example of completing with whitespace before double quotes:
events.event_attributes.code.filepath:"quickwit-indexing/src/actors/↑ "
- The returned completion would omit the final quote
"quickwit-indexing/src/actors/indexing_pipeline.rs. - Applying the completion would give us:
events.event_attributes.code.filepath:"quickwit-indexing/src/actors/indexing_pipeline.rs "which isn't ideal but is better than an extra double quote
fmassot
requested changes
Aug 17, 2024
uptickmetachu
force-pushed
the
feat/improved-autocomplete
branch
from
6db8dc5
to
2cb273f
Compare
uptickmetachu
force-pushed
the
feat/improved-autocomplete
branch
from
2cb273f
to
9a3eea6
Compare
|
Happy to add a Loom/video recording of the changes in action as well if that helps with the review. |
|
Not needed, will review it today! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi first time contribution here :)
My typescript is also bad so please be gentle and suggest feedback where neccessary!
Love quickwit but wanted to try a small PR to see how easy it was to make changes to the plugin and hopefully contribute some more changes in the future.
Motivation
Autocompletion is great but two things bugged me:
span_attributes.filename:"CURSOR_IS_HERE"the suggestions will be surrounded by quotes. When accepting the suggestion, the final quote is inserted before the ending quote and as such we end up with incorrect syntax ofspan_attributes.filename:"SUGGESTION"" <--extra quote