Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#20: Adding a functionality to download transmissions as .wav files. #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

otanim
Copy link

@otanim otanim commented Jul 1, 2021

The goal is to allow record transmissions, this resolves #20 issue.

With the following changes now you can set the following 2 new parameters for the transmitter:

  • downloadTransmission - type: boolean, default: false, indicates if the generated sound needs to be downloaded after its transmission,
  • downloadableTransmissionFileName - type: string, default: "transmission.wav", set's downloadable file's name.

Example:

const transmit = Quiet.transmitter({
    profile: profilename,
    clampFrame: false,
    onFinish: onTransmitFinish,
    downloadableTransmissionFileName: 'transmission.wav',
    downloadTransmission: true,
});

@brian-armstrong
Copy link
Member

Hi @otanim

Thanks for the PR.

I'd like this functionality to make use of libsndfile, same as the C library does so that they generate the same file. The JS building pipeline (via emscripten) will need to bundle libsndfile and then the JS layer can call into it using similar logic as the C encode_file.c program. I'd be happy to give suggestions on this process if it helps.

Cheers
Brian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving the generated audio for WAV or MP3
2 participants