Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile CONTROLLED R[XYZ] allowing symbolic parameters #833

Merged
merged 1 commit into from
Jul 19, 2022
Merged

compile CONTROLLED R[XYZ] allowing symbolic parameters #833

merged 1 commit into from
Jul 19, 2022

Conversation

stylewarning
Copy link
Member

This allows programs like

DECLARE t REAL
CONTROLLED RX(t) 0 1
CONTROLLED RY(t) 0 1
CONTROLLED RZ(t) 0 1

to be compiled. It's unclear whether the forked compiler should handle these.

See #832 for details.

@stylewarning stylewarning force-pushed the controlled-rotation branch 2 times, most recently from f45a876 to 7733a09 Compare July 19, 2022 00:55
@stylewarning
Copy link
Member Author

Ignore the force-pushes above. They were some typos and other goof-ups. Should be good-to-go now.

braised-babbage
braised-babbage approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@braised-babbage braised-babbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stylewarning stylewarning merged commit 121a26d into master Jul 19, 2022
@stylewarning stylewarning deleted the controlled-rotation branch July 19, 2022 22:46
@notmgsk
Copy link
Member

notmgsk commented Jul 20, 2022

:chefskiss:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braised-babbage braised-babbage braised-babbage approved these changes

@ecpeterson ecpeterson Awaiting requested review from ecpeterson

@notmgsk notmgsk Awaiting requested review from notmgsk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stylewarning @notmgsk @braised-babbage