#2008: Make max_idle_timeout negotiation commutative. #2009
+55
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Oct 9, 2024
djc
reviewed
Oct 9, 2024
mstyura
added a commit
to mstyura/quinn
that referenced
this pull request
Oct 9, 2024
mstyura
added a commit
to mstyura/quinn
that referenced
this pull request
Oct 9, 2024
mstyura
added a commit
to mstyura/quinn
that referenced
this pull request
Oct 9, 2024
# This is the 1st commit message: quinn-rs#2008: Make max_idle_timeout negotiation commutative. # This is the commit message quinn-rs#2: quinn-rs#2008: Store negotiated idle_timeout as Duration. # This is the commit message quinn-rs#3: quinn-rs#2009: Address code review feedback.
mstyura
force-pushed
the
gh-issue-2008
branch
2 times, most recently
from
c5882f4
to
11e6de0
Compare
Ensure that both endpoints can agree on the same idle_timeout value, regardless of the announced max_idle_timeout parameters. This fix addresses a corner case where a locally configured idle_timeout of 0 was used as the negotiated value instead of the non-zero max_idle_timeout provided by the remote side.
Ralith
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Thanks!
The original intent here was that users pass None to TransportConfig::max_idle_timeout, rather than Some(0), if no maximum timeout is desired. I wonder if we should revisit that interface to make this less of a footgun? For example, we could make IdleTimeout require a nonzero number of milliseconds, or round up to 1, or something to that effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2008.