実行スペースを指定できるようにする #200
Open
実行スペースを指定できるようにする #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPUでのテスト修正
add circuit batch update
Closed
KowerKoint
reviewed
Feb 12, 2025
include/scaluq/types.hpp
Outdated
| template <Precision Prec> | ||
| using Matrix = Kokkos::View<Complex<Prec>**, Kokkos::LayoutRight>; | ||
| template <Precision Prec, ExecutionSpace Space> | ||
| using Matrix = Kokkos::View<Complex<Prec>**, Space>; |
There was a problem hiding this comment.
LayoutRightやめてパフォーマンス変わりませんか
There was a problem hiding this comment.
#200 (comment) と同じ理由で消えてました！
戻します
Comment on lines
30
to
31
| {(std::int64_t)(state.dim() >> std::popcount(target_mask | control_mask)), | ||
| (std::int64_t)values.size()}), |
There was a problem hiding this comment.
static_castではだめだったんですか？
There was a problem hiding this comment.
手元でテストする際にいろいろ試していたら変わってたみたいです！
とくに理由はないので差し戻します．
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #140
support-more-precision ブランチにmergeしたいです．テストは編集していません