perf: Add max and min prefix counts to the generator #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-include the source of the bucket region error (it can be because you're not logged in). And discard duplicate error messages on print, not sure why they happen.
quodlibetor
force-pushed
the
more
branch
3 times, most recently
from
33d8124 to
a64006e
Compare
Add a min and max prefix count, since prefixes define the level of concurrency for the scan. Checking prefixes for validity is super slow, and running without any concurrency is also super slow. This will hopefully keep things reasonably fast
Searching for prefixes when there is no following delimiter seems to return nothing, which makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking prefixes for validity is super slow, and running
without any concurrency is also super slow.
This will hopefully keep things reasonably fast