Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] require CMake 3.20+ #349

Closed
wants to merge 5 commits into from
Closed

[WIP] require CMake 3.20+ #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e4ca48
require CMake 3.20+
BenWibking Aug 14, 2023
c7826b4
Merge branch 'development' into require-cmake-320
BenWibking Aug 29, 2023
2a135f0
use string with semicolon
BenWibking Aug 31, 2023
087294b
Merge branch 'require-cmake-320' of github.com:quokka-astro/quokka in…
BenWibking Aug 31, 2023
dd74bfd
set CUDA_ARCHITECTURES explicitly
BenWibking Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.16)
cmake_minimum_required(VERSION 3.20)
project(QuokkaCode VERSION 1.0
DESCRIPTION "Radiation hydrodynamics with structured AMR"
LANGUAGES CXX C)
Expand Down Expand Up @@ -39,11 +39,8 @@ if(AMReX_GPU_BACKEND MATCHES "CUDA")
message(FATAL_ERROR "You must use CUDA version 11.7 or newer to compile Quokka. All previous CUDA versions have compiler bugs that cause Quokka to crash.")
endif()

set(CMAKE_CUDA_ARCHITECTURES 70 80 CACHE STRING "")

if(CMAKE_VERSION VERSION_LESS 3.20)
include(AMReX_SetupCUDA)
endif(CMAKE_VERSION VERSION_LESS 3.20)
set(CMAKE_CUDA_ARCHITECTURES "70;80" CACHE STRING "")
set(CUDA_ARCHITECTURES "70;80" CACHE STRING "")
endif(AMReX_GPU_BACKEND MATCHES "CUDA")

if(CMAKE_CXX_COMPILER_ID STREQUAL "Intel")
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Quokka also features advanced Adaptive Quokka Refinement:tm: technology:

## Dependencies
* C++ compiler (with C++17 support)
* CMake 3.16+
* CMake 3.20+
* MPI library with GPU-aware support (OpenMPI, MPICH, or Cray MPI)
* HDF5 1.10+ (serial version)
* CUDA 11.7+ (optional, for NVIDIA GPUs)
Expand Down