update shock-cloud problem #350

BenWibking · 2023-08-16T18:50:36Z

This updates the shock-cloud problem to use a new setup that:

tracks the cloud center-of-mass frame
refines so that the cooling length $l_{\text{cool}} = c_s t_{\text{cool}}$ is resolved with at least 10 cells
adds derived fields for temperature, entropy, pressure, etc. to the outputs
uses the (simplified) Navier-Stokes Characteristic Boundary Conditions for inflow/outflow on the left/right sides of the box
adds shock-cloud problem to nightly regression testing

This PR depends on:

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 61. Check the log or trigger a new build to see more.

src/ShockCloud/cloud.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 51. Check the log or trigger a new build to see more.

src/ShockCloud/cloud.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 41. Check the log or trigger a new build to see more.

src/ShockCloud/cloud.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 31. Check the log or trigger a new build to see more.

src/ShockCloud/cloud.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 20. Check the log or trigger a new build to see more.

src/ShockCloud/cloud.cpp

github-actions

clang-tidy made some suggestions

src/ShockCloud/cloud.cpp

psharda · 2023-08-17T14:51:51Z

/azp run

psharda · 2023-08-30T04:14:42Z

/azp run

github-actions

clang-tidy made some suggestions

src/CloudyCooling.hpp

BenWibking · 2023-09-08T19:20:12Z

/azp run

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 16. Check the log or trigger a new build to see more.

src/GrackleDataReader.cpp

src/GrackleDataReader.hpp

github-actions

clang-tidy made some suggestions

src/GrackleDataReader.hpp

src/ShockCloud/cloud.cpp

src/simulation.hpp

github-actions

clang-tidy made some suggestions

src/ShockCloud/cloud.cpp

github-actions

clang-tidy made some suggestions

src/ShockCloud/cloud.cpp

review-notebook-app · 2023-11-05T19:14:10Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

BenWibking · 2023-11-05T19:14:26Z

/azp run

azure-pipelines · 2023-11-05T19:14:45Z

Azure Pipelines successfully started running 4 pipeline(s).

github-actions

clang-tidy made some suggestions

src/CloudyCooling.hpp

src/ShockCloud/cloud.cpp

github-actions

clang-tidy made some suggestions

src/simulation.hpp

github-actions

clang-tidy made some suggestions

src/simulation.hpp

src/GrackleDataReader.cpp

BenWibking · 2024-02-08T21:05:36Z

/azp run

azure-pipelines · 2024-02-08T21:06:01Z

Azure Pipelines successfully started running 5 pipeline(s).

src/hydro_system.hpp

github-actions

clang-tidy made some suggestions

src/CloudyCooling.hpp

src/GrackleDataReader.cpp

src/GrackleDataReader.hpp

src/ShockCloud/cloud.cpp

src/simulation.hpp

src/ShockCloud/test_cloudy_cooling.cpp

github-actions

clang-tidy made some suggestions

src/ShockCloud/test_cloudy_cooling.cpp

BenWibking · 2024-06-11T03:39:32Z

/azp run

azure-pipelines · 2024-06-11T03:39:46Z

Azure Pipelines successfully started running 2 pipeline(s).

BenWibking · 2024-06-11T12:30:51Z

/azp run

azure-pipelines · 2024-06-11T12:31:05Z

Azure Pipelines successfully started running 2 pipeline(s).

BenWibking · 2024-06-30T22:11:06Z

@markkrumholz I've added this problem to the nightly regression testing. It should be all ready to review.

BenWibking · 2024-06-30T22:11:20Z

/azp run

azure-pipelines · 2024-06-30T22:11:33Z

Azure Pipelines successfully started running 2 pipeline(s).

github-actions bot reviewed Aug 16, 2023

View reviewed changes

github-actions bot reviewed Aug 30, 2023

View reviewed changes

src/CloudyCooling.hpp Outdated Show resolved Hide resolved

src/CloudyCooling.hpp Outdated Show resolved Hide resolved

github-actions bot reviewed Sep 8, 2023

View reviewed changes

github-actions bot reviewed Sep 9, 2023

View reviewed changes

src/ShockCloud/cloud.cpp Show resolved Hide resolved

src/ShockCloud/cloud.cpp Show resolved Hide resolved

src/ShockCloud/cloud.cpp Outdated Show resolved Hide resolved

github-actions bot reviewed Sep 12, 2023

View reviewed changes

src/ShockCloud/cloud.cpp Outdated Show resolved Hide resolved

src/ShockCloud/cloud.cpp Outdated Show resolved Hide resolved

github-actions bot reviewed Nov 5, 2023

View reviewed changes

github-actions bot reviewed Dec 14, 2023

View reviewed changes

src/simulation.hpp Outdated Show resolved Hide resolved

github-actions bot reviewed Jan 22, 2024

View reviewed changes

src/simulation.hpp Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Feb 2, 2024

View reviewed changes

src/GrackleDataReader.cpp Fixed Show fixed Hide fixed

BenWibking commented Feb 11, 2024

View reviewed changes

src/hydro_system.hpp Outdated Show resolved Hide resolved

github-actions bot reviewed Apr 1, 2024

View reviewed changes

BenWibking force-pushed the BenWibking/new-shock-cloud branch from e907485 to 957a17b Compare April 14, 2024 02:44

github-advanced-security bot found potential problems Apr 14, 2024

View reviewed changes

src/ShockCloud/test_cloudy_cooling.cpp Fixed Show fixed Hide fixed

src/ShockCloud/test_cloudy_cooling.cpp Fixed Show fixed Hide fixed

github-actions bot reviewed Apr 14, 2024

View reviewed changes

src/ShockCloud/test_cloudy_cooling.cpp Outdated Show resolved Hide resolved

BenWibking force-pushed the BenWibking/new-shock-cloud branch from f2dffc6 to ba80826 Compare June 11, 2024 03:30

update shock-cloud problem

f42aee6

BenWibking force-pushed the BenWibking/new-shock-cloud branch from ba80826 to f42aee6 Compare June 11, 2024 03:33

Merge branch 'development' into BenWibking/new-shock-cloud

2c52fb4

BenWibking marked this pull request as ready for review June 11, 2024 12:33

BenWibking requested a review from markkrumholz June 11, 2024 12:37

BenWibking added 8 commits June 24, 2024 10:49

Merge branch 'development' into BenWibking/new-shock-cloud

af3e2c8

Merge branch 'development' into BenWibking/new-shock-cloud

2b0d279

add regression test

1639e56

change regression branch (for testing only)

3224c60

remove old inputs

0735ab3

update path

5dc7488

increase max sim time

f8b0298

Update quokka-tests.ini

365aa76

markkrumholz approved these changes Jun 30, 2024

View reviewed changes

BenWibking added this pull request to the merge queue Jul 1, 2024

Merged via the queue into development with commit d6728ef Jul 1, 2024
19 of 21 checks passed

BenWibking deleted the BenWibking/new-shock-cloud branch July 31, 2024 15:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update shock-cloud problem #350

update shock-cloud problem #350

BenWibking commented Aug 16, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

psharda commented Aug 17, 2023

psharda commented Aug 30, 2023

github-actions bot left a comment

BenWibking commented Sep 8, 2023

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

review-notebook-app bot commented Nov 5, 2023

BenWibking commented Nov 5, 2023

azure-pipelines bot commented Nov 5, 2023

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

BenWibking commented Feb 8, 2024

azure-pipelines bot commented Feb 8, 2024

github-actions bot left a comment

github-actions bot left a comment

BenWibking commented Jun 11, 2024

azure-pipelines bot commented Jun 11, 2024

BenWibking commented Jun 11, 2024

azure-pipelines bot commented Jun 11, 2024

BenWibking commented Jun 30, 2024

BenWibking commented Jun 30, 2024

azure-pipelines bot commented Jun 30, 2024

update shock-cloud problem #350

update shock-cloud problem #350

Conversation

BenWibking commented Aug 16, 2023 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

psharda commented Aug 17, 2023

psharda commented Aug 30, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

BenWibking commented Sep 8, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

review-notebook-app bot commented Nov 5, 2023

BenWibking commented Nov 5, 2023

azure-pipelines bot commented Nov 5, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

BenWibking commented Feb 8, 2024

azure-pipelines bot commented Feb 8, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

BenWibking commented Jun 11, 2024

azure-pipelines bot commented Jun 11, 2024

BenWibking commented Jun 11, 2024

azure-pipelines bot commented Jun 11, 2024

BenWibking commented Jun 30, 2024

BenWibking commented Jun 30, 2024

azure-pipelines bot commented Jun 30, 2024

BenWibking commented Aug 16, 2023 •

edited

Loading