-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add git hash to metadata output #888
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Changes generally look fine, but I have a question about how you expect the warning about untracked changes to work for people outside our research group, who do not have write access to our repo, but who will presumably want to create their own problem generators. Is the idea that they will create their own forks of the repo into which to check their problem setups, and the track changes warning will then be checked against their fork? Is the expectation that they should submit their problem setups to the main repo? |
I think we can be agnostic as to what branch the changes are committed to. As long as the changes have been committed (even only locally), then the resulting git hash can be used to uniquely identify what version of the source code produced it, since it's unique. |
@markkrumholz Let me know if this clarifies things. |
Looks good to me. |
Sorry, meant to close the conversation, not the PR. |
|
Description
This adds the git commit hash to
metadata.yaml
for plotfiles and checkpoints. This allows users to track the exact provenance of simulation outputs.Related issues
Closes #852.
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
x
inside the square brackets[ ]
in the Markdown source below:/azp run
.