Fix: Use default exports for humps library #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, running in ESM mode is causing failures due to the way
humps
is imported and bundled by tsup. The humps library provides uses default exports to export it's functionality.This becomes a problem for ESM bundling as
tsup
just includes the following line in theindex.min.mjs
bundle:Running in ESM mode causes failures because named exports are not present in the humps module.
Fix
Use default exports.
Steps to reproduce
npm install @quranjs/api
to install the package.Note on testing
I've tested this change using pnpm link to verify the changes.
I've thought hard about including unit tests but vitest does transpilation of imported modules behind the scenes due to which this issue is hard to reproduce while testing.