Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the new translation ui components into reusable NoorUI components #629

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

mohamede1945
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 188 lines in your changes are missing coverage. Please review.

Comparison is base (bcc4d69) 40.64% compared to head (88b7d87) 40.52%.

Files Patch % Lines
...rUI/Features/Quran/QuranTranslationTextChunk.swift 0.00% 42 Missing ⚠️
...QuranTranslationFeature/TranslationItem+View.swift 0.00% 36 Missing ⚠️
UI/NoorUI/Features/Quran/QuranArabicText.swift 0.00% 23 Missing ⚠️
UI/NoorUI/Features/Quran/QuranSuraName.swift 0.00% 21 Missing ⚠️
UI/NoorUI/Features/Quran/QuranTranslatorName.swift 0.00% 13 Missing ⚠️
...eatures/Quran/QuranTranslationReferenceVerse.swift 0.00% 12 Missing ⚠️
UI/NoorUI/Features/Quran/QuranPageHeader.swift 0.00% 11 Missing ⚠️
UI/NoorUI/Features/Quran/QuranPageFooter.swift 0.00% 9 Missing ⚠️
...atures/QuranImageFeature/ContentImageBuilder.swift 0.00% 8 Missing ⚠️
UI/NoorUI/Features/Quran/QuranVerseSeparator.swift 0.00% 7 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
- Coverage   40.64%   40.52%   -0.12%     
==========================================
  Files         518      526       +8     
  Lines       20977    21039      +62     
==========================================
  Hits         8526     8526              
- Misses      12451    12513      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamede1945 mohamede1945 merged commit c83a53a into main Feb 10, 2024
2 checks passed
@mohamede1945 mohamede1945 deleted the afifi branch February 10, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant