-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local mutated bookmarks persistence & The new bookmarks persistence #686
Open
mohannad-hassan
wants to merge
36
commits into
quran:main
Choose a base branch
from
mohannad-hassan:bookmarks-repo-merge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
==========================================
+ Coverage 40.92% 42.47% +1.54%
==========================================
Files 525 547 +22
Lines 20880 22373 +1493
==========================================
+ Hits 8546 9502 +956
- Misses 12334 12871 +537 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Decided to include #685 in this as well, to be able to review the mutations DB and how it's used. This, this and this are the open discussions from there.
Here's the description:
Introduces the repository for the local mutations database of bookmarks. This stores full records, but encapsulates the operation as well.
The backend's logic for bookmarks doesn't allow editing; only creation and removal.
This is the new bookmarks persistence that merges the synced DB and the mutations DB. This is intended to be used throughout the app in place of the CoreData persistence.
Not addressed in this PR:
I may handle the first point in this PR, but most likely I plan to separate it into a separate PR.