Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local mutated bookmarks persistence & The new bookmarks persistence #686

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

mohannad-hassan
Copy link
Collaborator

@mohannad-hassan mohannad-hassan commented Feb 28, 2025

Note: Decided to include #685 in this as well, to be able to review the mutations DB and how it's used. This, this and this are the open discussions from there.

Here's the description:
Introduces the repository for the local mutations database of bookmarks. This stores full records, but encapsulates the operation as well.

The backend's logic for bookmarks doesn't allow editing; only creation and removal.


This is the new bookmarks persistence that merges the synced DB and the mutations DB. This is intended to be used throughout the app in place of the CoreData persistence.

Not addressed in this PR:

  • How to handle the lifetime before the user connects the device to the Quran.com account.
  • Migrations.

I may handle the first point in this PR, but most likely I plan to separate it into a separate PR.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 97.32824% with 14 lines in your changes missing coverage. Please review.

Project coverage is 42.47%. Comparing base (d9fc366) to head (4203309).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
...ources/SynchronizablePageBookmarkPersistence.swift 87.30% 8 Missing ⚠️
...e/Sources/GRDBMutatedPageBookmarkPersistence.swift 95.95% 4 Missing ⚠️
...ests/GRDBMutatedPageBookmarkPersistenceTests.swift 98.68% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   40.92%   42.47%   +1.54%     
==========================================
  Files         525      547      +22     
  Lines       20880    22373    +1493     
==========================================
+ Hits         8546     9502     +956     
- Misses      12334    12871     +537     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohannad-hassan mohannad-hassan changed the title [Pending on #685] The new bookmarks persistence Local mutated bookmarks persistence & The new bookmarks persistence Mar 3, 2025
@mohannad-hassan mohannad-hassan marked this pull request as ready for review March 3, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant