Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the verse actions popup close automatically after the user starts playing a verse #2126

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

0XYoussefX0
Copy link

@0XYoussefX0 0XYoussefX0 commented Mar 28, 2024

Summary

when the user opens the modal to repeat a verse and clicks the start playing button, the modal stays open, This PR fixes that.
this fix was already requested by users in here

Screenshots

Before After
Before_1 After_2

Copy link

vercel bot commented Mar 28, 2024

@0XYoussefX0 is attempting to deploy a commit to the Quran Team on Vercel.

A member of the Team first needs to authorize it.

@0XYoussefX0 0XYoussefX0 changed the title Fix/close popup automatically made the verse actions popup close automatically after the user starts playing a verse Mar 28, 2024
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2024 8:34pm

@0XYoussefX0
Copy link
Author

@osamasayed can you please review my PR?

@osamasayed
Copy link
Member

@osamasayed can you please review my PR?

Alsalmau Alikum brother, Jazak Allahu Khairan for your contribution. Before I am able to review it please make sure it can build successfully as currently it's not working. You can try to run "yarn build" locally first.

@0XYoussefX0
Copy link
Author

@osamasayed done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants