Fixing the layout shift that happens in the home page and chapterId page #2130
+124
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0XYoussefX0 is attempting to deploy a commit to the Quran Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0XYoussefX0
force-pushed
the
fix/layout-shift
branch
from
d9e6255
to
5d2ffe2
Compare
|
@osamasayed @AhmedCodeGuy please can you review this PR ? |
|
@AhmedCodeGuy Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixed the layout shift that happens when you open the language dropdown, and when you open any of the drawers available on the navbar. the first one is caused by a library used by radix ui under the hood called: react-remove-scroll, and the second one is caused by the usePreventBodyScrolling hook.
Here is the Before and After