Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2145] Updated popover color in darkmode #2171

Open
wants to merge 1 commit into
base: testing
Choose a base branch
from

Conversation

mouhamaddev
Copy link

@mouhamaddev mouhamaddev commented Jun 16, 2024

Summary

Fixes #2145

This pull request addresses issue #2145, which highlights a color contrast problem with the popover component in dark mode. The background color of the popover was previously too similar to the main background, making it difficult to distinguish and reducing readability.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test plan

This pull request has been tested by manually verifying the new popover background color in dark mode to ensure it provides sufficient contrast against the main background. Additionally, it was confirmed that the changes do not affect the popover's appearance in light mode.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots or videos

Before After
Screenshot (170) Screenshot (171)

Copy link

vercel bot commented Jun 16, 2024

@mouhamaddev is attempting to deploy a commit to the Quran Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2024 11:37am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant