Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove right to left hack on root layout #3004

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Remove right to left hack on root layout #3004

merged 1 commit into from
Dec 7, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 7, 2024

Previously, in order to ensure the ayah toolbar was set properly, a hack
was in place to always ensure that the root RelativeLayout is LTR.
Removing this hack broke the ayah toolbar position. Adding it back,
however, broke the proper directionality of the audio bar.

This patch finally removes this hack and properly calculates the
position in RTL. Consequently, it fixes the audio bar directionality.

Previously, in order to ensure the ayah toolbar was set properly, a hack
was in place to always ensure that the root RelativeLayout is LTR.
Removing this hack broke the ayah toolbar position. Adding it back,
however, broke the proper directionality of the audio bar.

This patch finally removes this hack and properly calculates the
position in RTL. Consequently, it fixes the audio bar directionality.
Copy link

github-actions bot commented Dec 7, 2024

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │          uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff   
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │  24.1 MiB │  24.1 MiB │ +20 B │  74.7 MiB │  74.7 MiB │ +180 B 
     arsc │   2.7 MiB │   2.7 MiB │   0 B │   2.7 MiB │   2.7 MiB │    0 B 
 manifest │   5.8 KiB │   5.8 KiB │   0 B │    28 KiB │    28 KiB │    0 B 
      res │   1.7 MiB │   1.7 MiB │ -29 B │     2 MiB │     2 MiB │  -48 B 
   native │  18.8 KiB │  18.8 KiB │   0 B │  36.5 KiB │  36.5 KiB │    0 B 
    asset │ 404.2 KiB │ 404.2 KiB │   0 B │ 678.6 KiB │ 678.6 KiB │    0 B 
    other │ 218.4 KiB │ 218.4 KiB │  +1 B │ 464.6 KiB │ 464.6 KiB │    0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │  29.2 MiB │  29.2 MiB │  -8 B │  80.6 MiB │  80.6 MiB │ +132 B 

@ahmedre ahmedre added this pull request to the merge queue Dec 7, 2024
Merged via the queue into main with commit 5722de2 Dec 7, 2024
2 checks passed
@ahmedre ahmedre deleted the remove_rtl_hack branch December 7, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant