Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle audio updates api returning 204 #3065

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Jan 26, 2025

When there are no updates, the audio updates api returns 204. Gracefully
handle this by treating null as no data.

When there are no updates, the audio updates api returns 204. Gracefully
handle this by treating null as no data.
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │  24.2 MiB │  24.2 MiB │ +56 B │  74.8 MiB │  74.8 MiB │ +64 B 
     arsc │   2.7 MiB │   2.7 MiB │   0 B │   2.7 MiB │   2.7 MiB │   0 B 
 manifest │   5.8 KiB │   5.8 KiB │   0 B │    28 KiB │    28 KiB │   0 B 
      res │   1.7 MiB │   1.7 MiB │   0 B │     2 MiB │     2 MiB │   0 B 
   native │  18.8 KiB │  18.8 KiB │   0 B │  36.5 KiB │  36.5 KiB │   0 B 
    asset │ 404.2 KiB │ 404.2 KiB │   0 B │ 678.6 KiB │ 678.6 KiB │   0 B 
    other │ 218.3 KiB │ 218.3 KiB │  -1 B │ 464.6 KiB │ 464.6 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │  29.2 MiB │  29.2 MiB │ +55 B │  80.6 MiB │  80.6 MiB │ +64 B 

@ahmedre ahmedre added this pull request to the merge queue Jan 26, 2025
Merged via the queue into main with commit dc4fb26 Jan 26, 2025
2 checks passed
@ahmedre ahmedre deleted the fix_audio_update_error branch January 26, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant