ExportData: Prevent storing of data of unregistered extensions

qxmpp-project · Aug 18, 2024 · ee72d41 · ee72d41
1 parent 6974bbb
commit ee72d41
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/client/QXmppAccountMigrationManager.cpp b/src/client/QXmppAccountMigrationManager.cpp
@@ -147,6 +147,11 @@ void QXmppExportData::registerExtensionInternal(std::type_index type, ExtensionP
     accountDataSerializers().emplace(type, serialize);
 }
 
+bool QXmppExportData::isExtensionRegistered(std::type_index type)
+{
+    return accountDataSerializers().contains(type);
+}
+
 struct QXmppAccountMigrationManagerPrivate {
     template<typename T = Success>
     using Result = std::variant<T, QXmppError>;

diff --git a/src/client/QXmppAccountMigrationManager.h b/src/client/QXmppAccountMigrationManager.h
@@ -40,6 +40,7 @@ class QXMPP_EXPORT QXmppExportData
     template<typename T>
     void setExtension(T &&value)
     {
+        Q_ASSERT(isExtensionRegistered<T>());
         setExtension(std::any(std::move(value)));
     }
 
@@ -70,6 +71,9 @@ class QXMPP_EXPORT QXmppExportData
         registerExtensionInternal(std::type_index(typeid(T)), parseAny, serializeAny, tagName, xmlns);
     }
 
+    template<typename T>
+    static bool isExtensionRegistered() { return isExtensionRegistered(std::type_index(typeid(T))); }
+
 private:
     friend class QXmppAccountMigrationManager;
     friend class tst_QXmppAccountMigrationManager;
@@ -78,6 +82,7 @@ class QXMPP_EXPORT QXmppExportData
     void setExtension(std::any value);
 
     static void registerExtensionInternal(std::type_index, ExtensionParser<std::any>, ExtensionSerializer<std::any>, QStringView tagName, QStringView xmlns);
+    static bool isExtensionRegistered(std::type_index);
 
     QSharedDataPointer<QXmppExportDataPrivate> d;
 };