feat: add support for ROR #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
commented
Feb 4, 2025
| @@ -312,6 +312,11 @@ dt:target + dd { | |||
| color: #A6CE39; | |||
| margin-right: 4px; | |||
| } | |||
| // ror badge | |||
| .ror { | |||
| height: 16px; | |||
There was a problem hiding this comment.
maybe it should be bigger
There was a problem hiding this comment.
16px seems like a fine place to start
|
|
|
@maelle This looks good, did you want to do anything else before mergine? |
|
@maelle Can you add a news bullet? |
|
@jayhesselberth Thank you! Not sure why I had left it as draft. 😅 In any case I was waiting for a review 😁 |
jayhesselberth
approved these changes
Feb 28, 2025
|
|
||
| paste0( | ||
| "<a href='https://ror.org/", ror, "'>", | ||
| "<img src='https://raw.githubusercontent.com/ror-community/ror-logos/main/ror-icon-rgb.svg' class='ror' alt='ROR'></a>" |
There was a problem hiding this comment.
Should we use the version with transparent background?
https://github.com/ror-community/ror-logos/blob/main/ror-icon-rgb-transparent.svg
There was a problem hiding this comment.
wouldn't it look worse in dark mode?
| @@ -312,6 +312,11 @@ dt:target + dd { | |||
| color: #A6CE39; | |||
| margin-right: 4px; | |||
| } | |||
| // ror badge | |||
| .ror { | |||
| height: 16px; | |||
There was a problem hiding this comment.
16px seems like a fine place to start
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2850