Switch test expect_snapshot to explicit expect_warning

r-lib · Nov 26, 2023 · 4e40482 · 4e40482
1 parent efccac9
commit 4e40482
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/tests/testthat/_snaps/utils.md b/tests/testthat/_snaps/utils.md
diff --git a/tests/testthat/test-utils.R b/tests/testthat/test-utils.R
@@ -30,8 +30,7 @@ test_that("windows fallbacks work", {
 })
 
 test_that("check_version works as expected", {
-  expect_snapshot({
-    expect_equal(check_version("1", NULL), NULL)
-    expect_equal(check_version("1", "R"), "1")
-  })
+  expect_warning(out <- check_version("1", NULL), "version is ignored when appname is null")
+  expect_equal(out, NULL)
+  expect_equal(check_version("1", "R"), "1")
 })