Make skip_if_offline() more robust by checking multiple hosts (#1890)

r-lib · Nov 29, 2023 · b4275f9 · b4275f9
1 parent 6cb9a69
commit b4275f9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # testthat (development version)
 
+* `skip_if_offline()` now uses `captive.apple.com` by default. This is the 
+  host that Apple devices use to check that they're online so should be 
+  a higher reliability host than `r-project.org` (@jdblischak, #1890).
+
 * `test_file(desc = )` will now find `describe()` tests as well as `testthat()`
   tests (#1903).
 

diff --git a/R/skip.R b/R/skip.R
@@ -122,7 +122,7 @@ package_version <- function(x) {
 
 #' @export
 #' @rdname skip
-skip_if_offline <- function(host = "r-project.org") {
+skip_if_offline <- function(host = "captive.apple.com") {
   skip_on_cran()
   check_installed("curl")
 

diff --git a/man/skip.Rd b/man/skip.Rd