Skip to content

Commit

Permalink
require non-empty strings for test description
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinushey committed Aug 23, 2024
1 parent 93b88db commit f531c02
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# testthat (development version)

* `test_that()` now emits an error if `expect_snapshot()` is invoked within
a `test_that()` case with an empty description (#1980; @kevinushey).

# testthat 3.2.1

* Fix incorrect format string detected by latest R-devel. Fix thanks to
Expand Down
1 change: 1 addition & 0 deletions R/snapshot-reporter.R
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ SnapshotReporter <- R6::R6Class("SnapshotReporter",
tolerance = testthat_tolerance(),
variant = NULL,
trace_env = NULL) {
check_string(self$test, allow_empty = FALSE)
i <- self$new_snaps$append(self$test, variant, save(value))

old_raw <- self$old_snaps$get(self$test, variant, i)
Expand Down
8 changes: 8 additions & 0 deletions tests/testthat/test-snapshot.R
Original file line number Diff line number Diff line change
Expand Up @@ -162,3 +162,11 @@ test_that("hint is informative", {
cat(snapshot_accept_hint("foo", "bar.R", reset_output = FALSE))
})
})

test_that("expect_snapshot requires a non-empty test label", {

test_that("", {
expect_error(expect_snapshot(1 + 1))
})

})

0 comments on commit f531c02

Please sign in to comment.