Re-enable R's bytecode interpreter #458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to R's bytecode interpreter (TCO, more efficient use of stack space - thanks Luke!) mean it's now feasible to run it under Wasm by default. The R Wasm binary still grows a lot when the interpreter is included (by about 2MB!), but the reduction in complexity of our changes to R and potentially better runtime performance should make it worth it.
In particular, this might allow Shiny to run under Wasm without requiring hacks to reduce the size of the call stack.
Some things to be done before this can be merged:
[ ] - Run some benchmarks, get some real numbers on performance impact.
[ ] - Compare maximum depth with & without bytecode, e.g.
rec <- function(n){print(n); n * rec(n+1)}; rec(0)[ ] - Confirm loading non-byte-compiled Wasm R packages still works OK with this PR.
[ ] - Confirm loading byte-compiled Wasm packages works OK in previous releases of webR.
[ ] - Update
{rwasm}to start byte-compiling R packages during cross-compilation.[ ] - (Optional) Refresh https://repo.r-wasm.org for byte-compiled packages.
[ ] - Test byte-compiled Shiny under Wasm.