Chores/prep cran siane #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enchufa2
requested changes
Apr 7, 2018
DESCRIPTION
Outdated
| email = "[email protected]")) | ||
| Author: Carlos J. Gil Bellosta[aut, cre] | ||
| Nuno Carvalho[aut] | ||
| Author: Carlos J. Gil Bellosta [aut], |
There was a problem hiding this comment.
This field, as well as the Maintainer field, can be dropped if Authors@R is present, as it is the case. Advantages: remove duplications, easier to maintain.
LICENSE
Outdated
| @@ -0,0 +1,2 @@ | |||
| YEAR: 2017 | |||
LICENSE
Outdated
| @@ -0,0 +1,2 @@ | |||
| YEAR: 2017 | |||
| COPYRIGHT HOLDER: Your name goes here | |||
There was a problem hiding this comment.
Substitute Your name goes here with comma-separated names: Carlos J. Gil Bellosta, Nuno Carvalho.
DESCRIPTION
Outdated
| administrative level. The other main functionality is to bind numerical data to polygons. | ||
| This package is only compatible with the spanish IGN(National Institute of Geography) maps | ||
| and the INE(National Institute of Statistics) data. | ||
| Depends: plyr, raster, rgdal, sp, methods, utils |
There was a problem hiding this comment.
Packages in Depends are automatically loaded when the user loads your library. Does the user need them for using your package? If the answer is no for any of them, then they should be moved to Imports instead of Depends. See Other dependencies for further details about Depends and Imports.
Enchufa2
approved these changes
May 6, 2018
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created to solve issues #2 , #3 , #4 and #5.